Fixes #87 #88
Merged
Fixes #87 #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand what travis is complaining about ... Failed test result: While my php version is: |
|
Ignore Travis for now - I still need to get it working correctly on this repo.
…Sent from my iPhone
On Aug 31, 2019, at 4:11 PM, Fernando P ***@***.***> wrote:
I don't understand what travis is complaining about ...
Failed test result:
Problem 1
202 - phpunit/phpunit 7.5.x-dev requires php ^7.1 -> your PHP version (8.0.0-dev) does not satisfy that requirement.
203 - phpunit/phpunit 7.5.9 requires php ^7.1 -> your PHP version (8.0.0-dev) does not satisfy that requirement.
204...
While my php version is:
dev-server:myth-auth username$ php -v
PHP 7.3.8 (cli) (built: Aug 6 2019 23:15:07) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.8, Copyright (c) 1998-2018 Zend Technologies
with Zend OPcache v7.3.8, Copyright (c) 1999-2018, by Zend Technologies
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
oh, great! |
|
Any update on this @lonnieezell ? |
|
Sorry - just haven't had a chance to get back to it. it looks fine, though. My initial thought was that email should always be the defining characteristic, then I realized the system would allow either one (or anything else, really) to be the dominant fields, so it's all good :) |
|
Oh - and please don't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fallback to username when a non-existant user tries to log in